[risk=low][no ticket] Let Spring handle its own dependencies (and partially upgrade) #9049
+52
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmthibault79
commented
Jan 15, 2025
| // 1.5.7+ results in a runtime error: | ||
| // Logging system failed to initialize using configuration from 'null' | ||
| // java.lang.NoSuchMethodError: 'java.lang.Object ch.qos.logback.classic.LoggerContext.getConfigurationLock()' | ||
| LOGBACK_VERSION = '1.5.6' |
There was a problem hiding this comment.
The Spring plugin pulls in a compatible logback automatically. This PR brings it to 1.5.12.
jmthibault79
commented
Jan 15, 2025
| @@ -53,7 +49,9 @@ plugins { | |||
| id 'java' | |||
| id 'war' | |||
|
|
|||
| id 'io.spring.dependency-management' version '1.0.11.RELEASE' | |||
| id 'io.spring.dependency-management' version '1.1.7' | |||
jmthibault79
commented
Jan 15, 2025
| @@ -435,7 +466,6 @@ dependencies { | |||
| // 5.4+ results in a runtime error: | |||
| // java.lang.NoSuchMethodError: 'void org.apache.hc.core5.http.impl.io.DefaultHttpRequestWriterFactory.<init>(org.apache.hc.core5.http.config.Http1Config)' | |||
| implementation "org.apache.httpcomponents.client5:httpclient5:5.3.1" | |||
| implementation "org.springframework.boot:spring-boot-starter-validation:$project.ext.SPRING_BOOT_VERSION" | |||
There was a problem hiding this comment.
For most of the Spring dependencies:
- moved them up in the file
- grouped with other Spring packages
- removed version numbers
- removed exclusions (no longer needed)
jmthibault79
force-pushed
the
joel/spring
branch
from
108b552 to
bdae92f
Compare
|
Not sure why tests are failing in Circle. They passed for me locally. I was able to upgrade these packages manually anyway: #9051 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the Spring dependency management plugin instead of hardcoding. This allows us to stop hard-coding version numbers in many locations.
Also upgrade Spring, Spring-Boot, and Spring-Security to the latest 6.1.x, 3.3.x, and 6.3.x respectively. A full upgrade would be to 6.2, 3.4, and 6.4, but this would be nontrivial.
Tested locally by running Local UI and API.
PR checklist
[risk=no|low|moderate|severe]in the PR title as outlined in CONTRIBUTING.md.