Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[risk=low][RW-14230] Explicitly set scatter count for v8 too #9055

Merged
merged 5 commits into from
Jan 23, 2025

Conversation

jmthibault79
Copy link
Collaborator

@jmthibault79 jmthibault79 commented Jan 17, 2025

Running this command took only ~45 minutes on this branch

./project.rb run-extraction \
--project all-of-us-rw-prod \
--namespace aou-rw-a2626269 \
--dataset_id 117923 \
--person-ids "1123013,1466961" \
--legacy false \
--filter_set echo_full \
--cdr_bq_project fc-aou-cdr-prod-ct \
--wgs_bq_dataset wgs_C2024Q3

The same command on main for comparison (TODO capture total time)


PR checklist

  • I have included an issue ID or "no ticket" in the PR title as outlined in CONTRIBUTING.md.
  • I have included a risk tag of the form [risk=no|low|moderate|severe] in the PR title as outlined in CONTRIBUTING.md.
  • I have manually tested this change and my testing process is described above.
  • This change includes appropriate automated tests, and I have documented any behavior that cannot be tested with code.
  • I have added explanatory comments where the logic is not obvious.
  • One or more of the following is true:
    • This change is intended to complete a JIRA story, so I have checked that all AC are met for that story.
    • This change fixes a bug, so I have ensured the steps to reproduce are in the Jira ticket or provided above.
    • This change impacts deployment safety (e.g. removing/altering APIs which are in use), so I have documented the impacts in the description.
    • This change includes a new feature flag, so I have created and linked new JIRA tickets to (a) turn on the feature flag and (b) remove it later.
    • This change modifies the UI, so I have taken screenshots or recordings of the new behavior and notified the PO and UX designer in Slack.
    • This change modifies API behavior, so I have run the relevant E2E tests locally because API changes are not covered by our PR checks.
    • None of the above apply to this change.

@jmthibault79 jmthibault79 force-pushed the joel/scatter branch 2 times, most recently from 822c70f to 3f2e43c Compare January 21, 2025 21:42
@jmthibault79 jmthibault79 changed the title TEMP always set scatter count [risk=low][RW-14230] Explicitly set scatter count for v8 too Jan 22, 2025
@jmthibault79 jmthibault79 marked this pull request as ready for review January 22, 2025 21:52
@jmthibault79 jmthibault79 requested review from a team, freemabd and evrii and removed request for a team and freemabd January 22, 2025 22:26
Copy link
Contributor

@Qi77Qi Qi77Qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the wdl input for scatter count's param name has changed?

@jmthibault79
Copy link
Collaborator Author

@Qi77Qi yes for v8

@jmthibault79 jmthibault79 merged commit 581f31d into main Jan 23, 2025
7 checks passed
@jmthibault79 jmthibault79 deleted the joel/scatter branch January 23, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants