Added Japanese support #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #148 +/- ##
============================================
- Coverage 98.83% 98.70% -0.14%
- Complexity 513 535 +22
============================================
Files 76 81 +5
Lines 2058 2157 +99
Branches 79 83 +4
============================================
+ Hits 2034 2129 +95
- Misses 12 14 +2
- Partials 12 14 +2 ☔ View full report in Codecov by Sentry. |
jglaszka
reviewed
Nov 24, 2023
| @@ -319,6 +322,31 @@ public static Container swedishContainer() { | |||
| return new Container(swedishNumberToWordsConverter, swedishNumberToWordsConverter, swedishBigDecimalConverter); | |||
| } | |||
|
|
|||
| public static Container japaneseContainer() { | |||
There was a problem hiding this comment.
just one suggestion - can you name it japaneseKanjiContainer, please? and also rename it in readme + in enums JAPANESE_LONG -> JAPANESE_KANJI_LONG. In the future, someone may implement it in hiragana
jglaszka
approved these changes
Nov 24, 2023
|
Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #142
I implemented Integer, Long and BigDecimal converter for Japanese.
I checked all tests passed.
Could you review this PR?