Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module wrapper #271

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

Module wrapper #271

wants to merge 20 commits into from

Conversation

AkshitaB
Copy link
Contributor

@AkshitaB AkshitaB commented Apr 15, 2022 •
edited
Loading

NOTE: Absolute mess, do not attempt to review.

Fixes #270

Changes proposed in this pull request:

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

@AkshitaB AkshitaB marked this pull request as draft April 15, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move fairscale::with_wrapped_modules logic to a separate argument in the trainer
1 participant
@AkshitaB