Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UX of Settings Page #125

Closed
kevinfodness opened this issue Feb 5, 2025 · 4 comments
Closed

Update UX of Settings Page #125

kevinfodness opened this issue Feb 5, 2025 · 4 comments
Assignees
Labels
javascript Requires understanding JavaScript php Requires understanding PHP
Milestone

Comments

@kevinfodness
Copy link
Member

Description

A recent WordPress update broke the display of the settings page, and it needs to be corrected.

Acceptance Criteria

  • Update the display of the settings page (Settings > SEO) so that it uses current WordPress classes/standards, properly depends on the styles and scripts that need to be enqueued in order for it to work (we were likely assuming particular CSS and JS would always be enqueued and they may not be any longer in new versions of WP), and otherwise looks like the settings page should.
  • Refactor out the use of jQuery on this page.

Use Case

A user utilizing the settings page should get a UI that doesn't look broken.

@kevinfodness kevinfodness added enhancement New feature or request javascript Requires understanding JavaScript php Requires understanding PHP labels Feb 5, 2025
@kevinfodness kevinfodness added this to the v2.0.0 milestone Feb 5, 2025
@kevinfodness kevinfodness removed the enhancement New feature or request label Feb 5, 2025
@mogmarsh
Copy link

duplicate of #127 ?

@kevinfodness
Copy link
Member Author

Closing as duplicate.

@anubisthejackle
Copy link

Reopened since it's in progress, and there are some specific AC here that aren't on #127

@samhermes
Copy link

Resolved by #136

The visual issues mentioned in this ticket were resolved by a core update, and we decided to stick with the accordions provided by core for the settings page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Requires understanding JavaScript php Requires understanding PHP
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants