Issue-125: Update UX of Settings Page

[samhermes]

Summary

Fixes #125

The display issues with repeatable fields on the settings page have been resolved, and anchor tags have been swapped out in favor of button elements where appropriate. The use of jQuery on the settings page has also been refactored out.

Changes Made

• Spacing adjusted around repeatable field groups
• Removed jQuery dependency from the settings page

Testing Instructions

1. Navigate to the settings page (Settings > SEO).
2. Verify that all functionalities on the page work without errors.
3. Navigate to an "Add New" taxonomy term page.
4. Verify that the character counts work when adding a new term.
5. Navigate to the post editor screen on a post type where the plugin is enabled.
6. Verify that the character counts work when updating the title or description in the SEO settings.

[mboynes]

A couple of general notes/questions:

• Since the script still depends on jquery, it feels like this didn't achieve one of the primary objectives.
• While not part of the "AC", inasmuch as there was any, it would have been nice to also get rid of the underscores dependency.
• Why not leverage React? Seems like this could have been much simpler with React.
• Also not a part of the "AC", but the scripts and styles are enqueued on every admin request, it would be good to use this as an opportunity to reign that in.

[mogmarsh]

👍

[mogmarsh]

I'm guessing we're stuck with this one because core is using it?

[samhermes]

Yeah, I've looked at alternate ways of handling this, and there just isn't a good option. The form gets submitted by jQuery, and we need to listen to the jQuery event for the submission, it's not available in vanilla JS.

[mogmarsh]

totally makes sense. ship it

[samhermes]

@mboynes I created #139 for tracking the scripts and styles enqueue updates. We need to remove the standard meta fields from the block editor, since it's being replaced by the slotfill, then we can avoid enqueuing the script there.

Agreed about React, it would have made this much easier, and made it easy to get rid of the Underscores dependency as well.