Feature/issue 130/finish migrating tests to new format #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mboynes
reviewed
Feb 26, 2025
tests/Feature/WPTitleWPHeadTest.php
Outdated
Comment on lines
105
to
107
| ob_start(); | ||
| WP_SEO()->wp_head(); | ||
| $html = ob_get_clean(); |
There was a problem hiding this comment.
There was a problem hiding this comment.
Aha.
I copied this pattern from the tests Greg already migrated,so we might need to revisit those too.
Co-authored-by: Travis Weston <[email protected]>
mogmarsh
approved these changes
Mar 3, 2025
| @@ -24,21 +31,22 @@ function test_get_term_option() { | |||
|
|
|||
| function test_intersect_term_option() { | |||
| $this->assertCount( | |||
| 3, | |||
| WP_SEO::instance()->intersect_term_option( array() ), | |||
| 2, | |||
There was a problem hiding this comment.
This is testing this function, the count having changed because we've removed keywords from the defaults.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.