Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding help text for seq details. #1203

Merged
merged 2 commits into from
Sep 27, 2023
Merged

adding help text for seq details. #1203

merged 2 commits into from
Sep 27, 2023

Conversation

scottcain
Copy link
Collaborator

I’m adding help text for the sequence details section but since I’ve been unable to get the website to run locally I’m committing untested code. I imagine that it is sufficiently simple that I’m likely to get it right, but somebody please really check for real :-)

@chris-grove
Copy link
Member

@scottcain The stage branch has already (as in, yesterday or Monday) been pushed to test.alliancegenome.org, so any changes pushed to stage (as of now) will not be pushed out for 6.0.0. If we really want this in for 6.0.0, we need to discuss whether we can get it into the test branch for the release

@chris-grove
Copy link
Member

@scottcain Sorry, since this is the UI repo, my statement may not be valid as we now have an independent build for UI changes

@scottcain
Copy link
Collaborator Author

Bad news and moderately good news: this PR is flawed and I have to figure out what's wrong. The moderately good news: I did get the website running locally on my ubuntu vm.

@scottcain scottcain disabled auto-merge September 27, 2023 18:46
@scottcain scottcain changed the title adding help text for seq details. UNTESTED! adding help text for seq details. DO NOT MERGE Sep 27, 2023
@scottcain scottcain marked this pull request as draft September 27, 2023 18:48
@scottcain scottcain marked this pull request as ready for review September 27, 2023 19:27
@scottcain scottcain changed the title adding help text for seq details. DO NOT MERGE adding help text for seq details. Sep 27, 2023
@scottcain
Copy link
Collaborator Author

Fixed a silly formatting issue. This can be merged if possible.

@scottcain scottcain merged commit 916aa05 into stage Sep 27, 2023
3 checks passed
@scottcain scottcain deleted the seqpanel_helptext branch September 27, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants