-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deps #1233
Update deps #1233
Conversation
This reverts commit 1a53d79.
@adamgibs i doubt these are your errors but i think we should try to clean them up before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After deleting node_modules, npm build throws:
internal/modules/cjs/loader.js:818
throw err;
^
Error: Cannot find module 'webpack'
@oblodgett Yeah, the create react app eslint settings are set up to catch different things so now things in the older code is being caught. I can fix some of the issues now. However, I think the anchor tag errors should be their own ticket since that's more of a refactor. |
@abecerra Try this:
|
I forgot to delete package-lock.json. Gene and allele pages look good! |
Maybe it would be worth preserving the .editorconfig file? |
@abecerra That's a good point. I don't know if the |
Update UI to use CRA