Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps #1233

Merged
merged 15 commits into from
Dec 22, 2023
Merged

Update deps #1233

merged 15 commits into from
Dec 22, 2023

Conversation

adamgibs
Copy link
Contributor

@adamgibs adamgibs commented Dec 20, 2023

Update UI to use CRA

@oblodgett
Copy link
Member

@adamgibs i doubt these are your errors but i think we should try to clean them up before merging.

Copy link
Contributor

@abecerra abecerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After deleting node_modules, npm build throws:

internal/modules/cjs/loader.js:818
throw err;
^

Error: Cannot find module 'webpack'

@adamgibs
Copy link
Contributor Author

@oblodgett Yeah, the create react app eslint settings are set up to catch different things so now things in the older code is being caught. I can fix some of the issues now. However, I think the anchor tag errors should be their own ticket since that's more of a refactor.

@adamgibs
Copy link
Contributor Author

adamgibs commented Dec 21, 2023

@abecerra Try this:

  • delete node_modules
  • delete package-lock.json
  • run npm install --legacy-peer-deps
  • run npm run build
  • run make uirunstage

@abecerra
Copy link
Contributor

@abecerra Try this:

  • delete node_modules
  • delete package-lock.json
  • run npm install --legacy-peer-deps
  • run npm run build
  • run make uirunstage

I forgot to delete package-lock.json. Gene and allele pages look good!

@abecerra
Copy link
Contributor

Maybe it would be worth preserving the .editorconfig file?

@adamgibs
Copy link
Contributor Author

@abecerra That's a good point. I don't know if the .editorconfig file would work the same in a CRA app. It's worth looking into.

@adamgibs adamgibs merged commit 39fd47f into stage Dec 22, 2023
2 checks passed
@adamgibs adamgibs deleted the update-deps branch December 22, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants