Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCRUM-3604: render Add Impl Genes and Str Background only in Gene page #1242

Merged
merged 1 commit into from
Jan 16, 2024
Merged

SCRUM-3604: render Add Impl Genes and Str Background only in Gene page #1242

merged 1 commit into from
Jan 16, 2024

Conversation

abecerra
Copy link
Contributor

No description provided.

oblodgett
oblodgett reviewed Jan 11, 2024
View reviewed changes
Copy link
Member

@oblodgett oblodgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this help with the code reuse vs having two components?

@aws-amplify-us-east-1 AWS Amplify (us-east-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1242.dqm14ay4bsnu9.amplifyapp.com

@abecerra abecerra changed the title SCRUM-3604: render Add Impl Genes and Str Backrground only in Allele page SCRUM-3604: render Add Impl Genes and Str Backrground only in Gene page Jan 11, 2024
@abecerra abecerra changed the title SCRUM-3604: render Add Impl Genes and Str Backrground only in Gene page SCRUM-3604: render Add Impl Genes and Str Background only in Gene page Jan 11, 2024
@abecerra
Copy link
Contributor Author

Does this help with the code reuse vs having two components?

Yes, the same component is called in the Gene and Allele page.

But, I don't know about the AnnotatedEntitiesPopup component (the old) and the other pages that are using it.

@abecerra abecerra requested a review from cmpich January 12, 2024 16:33
adamgibs
adamgibs approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@adamgibs adamgibs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abecerra This works for now I think. In the future, if we need to use more and more conditional logic like this, it may make sense to refactor this component into two or more components that share core logic.

@abecerra abecerra merged commit 47ce6cf into stage Jan 16, 2024
3 checks passed
@abecerra abecerra deleted the SCRUM-3604 branch January 16, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oblodgett oblodgett oblodgett left review comments

@adamgibs adamgibs adamgibs approved these changes

@cmpich cmpich Awaiting requested review from cmpich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abecerra @oblodgett @adamgibs