Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS2 ConVar RE #154

Merged
merged 48 commits into from
Feb 15, 2025
Merged
Changes from 1 commit
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
1600e7f
progress report
Kenzzer Oct 4, 2023
03369af
clean up flags
Kenzzer Oct 5, 2023
6ac7e32
progress report
Kenzzer Oct 5, 2023
37a7655
remove some debug
Kenzzer Oct 5, 2023
c671207
Template the convar class
Kenzzer Oct 6, 2023
2558e41
progress report
Kenzzer Oct 7, 2023
ed18156
undo automatic symbol change
Kenzzer Oct 7, 2023
8429213
Get rid of ConCommandRefAbstract
Kenzzer Oct 7, 2023
8774df6
remove debug
Kenzzer Oct 7, 2023
79e18af
reorganise the headers, and add templated getter/setters
Kenzzer Oct 7, 2023
780666c
finish templating job
Kenzzer Oct 7, 2023
c3ac082
fix copyright symbol
Kenzzer Oct 7, 2023
0e8b1a5
dont break metamod compilation
Kenzzer Oct 7, 2023
fc063e1
template the entire ConVar class
Kenzzer Oct 8, 2023
61323eb
template change callback
Kenzzer Oct 8, 2023
4ebc6ac
Use MAX_SPLITSCREEN_CLIENTS for IConVar definition
Kenzzer Oct 8, 2023
1977558
split convarhandle once more + template iconvar
Kenzzer Oct 8, 2023
9b66bab
Renaming IConVar and depollute ICVar
Kenzzer Oct 8, 2023
7ededcc
remove static_assert + IDA comments
Kenzzer Oct 8, 2023
cdd1aca
renaming struct properties
Kenzzer Oct 8, 2023
f17c0bd
undo icommandline change
Kenzzer Oct 8, 2023
b682b73
make reglist simpler
Kenzzer Oct 8, 2023
13e111d
Destroy ConCommandBase
Kenzzer Oct 8, 2023
2c442df
move some functions to baseconvardata
Kenzzer Oct 8, 2023
e8f353e
put cvar values into its own struct
Kenzzer Oct 8, 2023
782a488
revise struct
Kenzzer Oct 8, 2023
5d63cc8
remove padding
Kenzzer Oct 8, 2023
960ccb0
add back unknown
Kenzzer Oct 8, 2023
47f939d
finish templating
Kenzzer Oct 8, 2023
5c806c8
fix wrong ret value
Kenzzer Oct 8, 2023
adb77b9
review changes
Kenzzer Oct 9, 2023
2382f23
small mistake
Kenzzer Oct 9, 2023
9def682
setup times changed
Kenzzer Oct 9, 2023
34fd0ef
expose handle
Kenzzer Oct 9, 2023
f8d22f9
add character_t include to icvar
Kenzzer Oct 29, 2023
38edca2
Streamline build for others
Kenzzer Feb 7, 2024
ae3cbcb
Update command completion cb signatures
GAMMACASE Jan 26, 2025
b29c4b2
Update ConVarValueInfo_t & CConVarBaseData
GAMMACASE Jan 26, 2025
72408e8
Update CCommand
GAMMACASE Jan 30, 2025
29edecb
Update ICvar
GAMMACASE Jan 30, 2025
df333bc
Update ConCommand & cb structs
GAMMACASE Jan 31, 2025
1b7d870
Fix few typos
GAMMACASE Feb 1, 2025
6a37763
Add ConVarRefAbstract & update ConVar api
GAMMACASE Feb 7, 2025
7324340
Add CCvar
GAMMACASE Feb 7, 2025
8ba042b
Cleanup CONVAR_WORK_FINISHED defines
GAMMACASE Feb 7, 2025
0b63780
Few small corrections
GAMMACASE Feb 10, 2025
8e5bebd
Remove ConCommandBase declaration
GAMMACASE Feb 11, 2025
ebb5d6b
Add concommand/convar register callbacks
GAMMACASE Feb 11, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
dont break metamod compilation
Kenzzer committed Jan 25, 2025
commit 0e8b1a5559f021e0f4f8a92e83f0f9955ed4ca97
10 changes: 8 additions & 2 deletions public/tier1/convar.h
Original file line number Diff line number Diff line change
@@ -351,8 +351,14 @@ struct ConCommandCreation_t : CVarCreationBase_t
};
static_assert(sizeof(ConCommandCreation_t) == 0x40, "ConCommandCreation_t is of the wrong size!");

class ConCommandBase {}; // For metamod compatibility only!!!!
class ConCommand : public ConCommandBase
// TO-DO: Remove this...
class ConCommandBase
{
public:
inline const char* GetName() { return "Please remove the ConCommandBase class..."; }
}; // For metamod compatibility only!!!!

class ConCommand
{
public:
ConCommand( const char *pName, FnCommandCallback_t callback,