- Fixes for OnPlayerTeleport hook for linux and linux64 systems

[MrD4rk5oul]

• Changed signature call of CanPlayerTeleport for linux/linux64 to current used name
• Applied fix at detour class CanPlayerBeTeleported to use standard parameter proceedings for linux

Fixes issue #2140

Fix tested on:

• Linux Mint 21.3, built in Ubuntu 20.04, working properly
• Windows 10, working properly

[psychonic]

Thanks!

[Arie]

The merging of this pull request coincides with crashes starting on my TF2 servers. PR was merged Nov 2 16:38CET, first crash at 17:02, up to about 40 crashes now. Servers were on Sourcemod 1.12.0.7116, just now upgraded to 1.12.0.7166 hoping that will fix the crashing.

Throttle shows server_srv.so!CObjectTeleporter::PlayerCanBeTeleported(CTFPlayer*) [clone .part.0] + 0x28 , which I've never seen before and seems too much of a coincidence.
https://crash.limetech.org/f7kccntfqfeb

[MrD4rk5oul]

The merging of this pull request coincides with crashes starting on my TF2 servers. PR was merged Nov 2 16:38CET, first crash at 17:02, up to about 40 crashes now. Servers were on Sourcemod 1.12.0.7116, just now upgraded to 1.12.0.7166 hoping that will fix the crashing.

Throttle shows server_srv.so!CObjectTeleporter::PlayerCanBeTeleported(CTFPlayer*) [clone .part.0] + 0x28 , which I've never seen before and seems too much of a coincidence. https://crash.limetech.org/f7kccntfqfeb

Further testing revealed multiple 3rd party plugins may cause the crash upon hooking on the game's events.

Using a bare TF2 server with MM+SM and a plugin hooking on CanPlayerTeleport yields no crashes.
Using a bare TF2 server with MM+SM and a plugin hooking on CanPlayerTeleport and another plugin hooking on TF2_OnWaitingForPlayersStart/TF2_OnWaitingForPlayersEnd leads to a crash upon touching a teleporter.

Current quick-fix solution should be :

• Modify the CanPlayerTeleport signature in gamedata/sm-tf2.games.txt back to @_ZN17CObjectTeleporter21PlayerCanBeTeleportedEP9CTFPlayer both in linux and linux64
• Set DisableAutoUpdate to yes in configs/core.cfg for the time being

The CanPlayerTeleport will stop working again until a solution comes up.

[psychonic]

This has now been reverted until a proper fix can be made