-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(syn-solidity): add statements and expressions #199
Conversation
when writing rustdoc for the structs, can you reference the corresponding structure in the solidity grammar for each type? |
oooo like this yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice - the idea here is to comptime transpile solidity to rust directly w/o jit'ing into any lower level code rigth?
yeah exactly. also a lot more user friendly to work with. I need to write some tests and stuff but super busy with work rn so the progress will be slow for the next little bit. Ik some of the Primitive devs where also interested in doing a paper based off the results not only looking at speed differences but llvm compile difference when comparing to revm. |
Hey @Will-Smith11, I have some free time these coming days, do you mind if I pick this up? |
go for it! |
521c739
to
83e135f
Compare
d2ed102
to
72ad57f
Compare
@DaniPopes What is left to be done? I have some free time this weekend and want to push this forward? |
Not much, the only thing is testing that the parsed output is what we expected, instead of just "it parses". Also operation order might not be entirely correct |
👍 |
@Will-Smith11 would love if you PoC'ed a benchmark comparing Revm+Solidity compiled vs native transpiled with syn-solidity, Im curious how you see this working for e.g. projects like uniswap-v3 |
Merging for now, will open a few issues with what's missing. |
Cooking for another project and thought why not make a pr request. I gotta do testing and im pretty sure ive missed a few cases. However just going to keep cooking at ethcc and will do cleanup later