migrate EIP 4844 #27
Open
migrate EIP 4844 #27
+6,051
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadtech-hub
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
prestwich
as code owners
mattsse
requested changes
Jan 6, 2025
crates/common/src/lib.rs
Outdated
| @@ -0,0 +1,48 @@ | |||
|
|
|||
There was a problem hiding this comment.
this crate can disable std, see
eips/crates/eip2930/src/lib.rs
Line 4 in 8794306
There was a problem hiding this comment.
i wonder, in what cases it could be disabled
|
overall, It needs improvements |
Signed-off-by: nadtech-hub <taberlick@gmail.com>
Signed-off-by: nadtech-hub <taberlick@gmail.com>
Signed-off-by: nadtech-hub <taberlick@gmail.com>
Signed-off-by: nadtech-hub <taberlick@gmail.com>
Signed-off-by: nadtech-hub <taberlick@gmail.com>
Signed-off-by: nadtech-hub <taberlick@gmail.com>
Signed-off-by: nadtech-hub <taberlick@gmail.com>
Signed-off-by: nadtech-hub <taberlick@gmail.com>
Signed-off-by: nadtech-hub <taberlick@gmail.com>
Signed-off-by: nadtech-hub <taberlick@gmail.com>
Signed-off-by: nadtech-hub <taberlick@gmail.com>
Signed-off-by: nadtech-hub <taberlick@gmail.com>
Signed-off-by: nadtech-hub <taberlick@gmail.com>
Signed-off-by: nadtech-hub <taberlick@gmail.com>
Signed-off-by: nadtech-hub <taberlick@gmail.com>
nadtech-hub
force-pushed
the
nadtech/migrate-eip4844
branch
from
c30adb9 to
73e4084
Compare
rakita
reviewed
Feb 13, 2025
|
|
||
| /// KZG settings. | ||
| #[derive(Clone, Debug, Default, Eq)] | ||
| pub enum EnvKzgSettings { |
There was a problem hiding this comment.
Default kzg settup can be found in c-kzg lib behind ethereum_kzg_settings features, this would slim down this PR by a lot.
It is a function c_kzg::ethereum_kzg_settings()
There was a problem hiding this comment.
you meant that enum's Default option can be remove, correct?
There was a problem hiding this comment.
@mattsse removing functionality from here is breaking change. shall I remove anything from env_settings?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
PR Checklist