feat: add error traits and ATs #11
Open
+103
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Feb 7, 2025
| @@ -14,12 +21,17 @@ use revm::{ | |||
| /// Executing a transaction will return the outcome of the transaction. | |||
| pub trait Evm { | |||
| /// Database type held by the EVM. | |||
| type DB: Database; | |||
| type DB; | |||
There was a problem hiding this comment.
it's actually just a workaround for weird trait bounds issue :/ we still require DB: Database on EvmFactory
|
ci is failing because current revm feature-gates |
|
since this is a new release basically revm ideally bumps msrv so we can use core |
is it possible to ship a std only version of this first of all, so I can base re-impl of paradigmxyz/reth#14124 on main with paradigmxyz/reth#14021 merged? that way we can work in parallel and be more efficient. alt is there a revm issue for making |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Extracts some API changes from #7 to make it easier to prototype with reth in scope of paradigmxyz/reth#14021
Solution
PR Checklist