Rewrite the /remindme command
#541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as duplicate.
This comment was marked as duplicate.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…handle exceptions and prevent app crash feat(remindme.py): add logging of errors when sending reminders fails to improve error tracking and debugging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, the
/remindmecommand is fully rewritten. A Task checks for unsent reminders every 5 minutes and attempts to send them in this order:A remindme is always marked as
sentif an attempt is made, regardless of whether it succeeded. Such attempt can only fail if the target's DMs are closed and the invoke channel was deleted or perms were changed to deny Tux send_messages access.Summary by Sourcery
Rewrite the
/remindmecommand to use a periodic task for checking and sending unsent reminders, enhancing the reliability and efficiency of the reminder system.New Features:
Enhancements:
/remindmecommand to improve the reminder sending logic and handling of unsent reminders.