Updates to Moderation Cog #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as spam.
This comment was marked as spam.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Is this ready for review? |
style(moderation): remove underscores from embed field titles for consistency refactor(moderation): simplify embed description assignment for DM status chore(moderation): remove commented-out code for cleaner codebase
…bed fields style(moderation): prefix DM status with '-#' for better visual distinction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #553
This PR fixes several issues, and proposes the removal of the
delete_afterparameter in all moderation and config commands.Fixes & improvements:
ctx.defer()to mod commands that take a while to process, to output "bot is thinking..." while waiting.asyncio.gather()to some commands, allowing it to process multiple async actions at the same time.PLR0911quality assurance (too many return statements)config.pyto implementinteraction.followup.sendinstead ofinteraction.response.send_messageRemove self-deletion is ephemeral commands:
delete_afterparameter is removed in the moderation outputs, they are already ephemeral if used as Slash Command. Additionally, the same counts for output fromconfig.py- they are all exclusively ephemeral interaction commands.