Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allure.SpecFlow improvements #462

Merged
merged 16 commits into from
Mar 28, 2024
Merged

Allure.SpecFlow improvements #462

merged 16 commits into from
Mar 28, 2024

Conversation

delatrie
Copy link
Contributor

@delatrie delatrie commented Mar 27, 2024 •
edited
Loading

Changes

Enhancements

Internal changes

  • Allure-specflow related projects were renamed:
    • Allure.SpecFlowPlugin -> Allure.SpecFlow (the assembly name and the root namespace remain the same).
    • AllureSpecFlowPlugin.Tests -> Allure.SpecFlow.Tests
    • Allure.Features -> Allure.SpecFlow.Tests.Samples
  • The Allure.SpecFlow integration tests now invoke a correct configuration of the samples project. Previously, the Debug configuration was always invoked regardless of the test run configuration.
  • The integration tests now collect the result files in a temp directory instead of relying on the heuristics to find one under the samples project output directory.
  • Apply the standard formatting to some stale code in Allure.SpecFlow test projects.

@delatrie delatrie self-assigned this Mar 27, 2024
@delatrie delatrie changed the title Specflow fixes 2403 Allure.SpecFlow improvements Mar 27, 2024
@delatrie delatrie force-pushed the specflow-fixes-2403 branch 2 times, most recently from b69b6ca to d550de0 Compare March 27, 2024 23:13
@delatrie delatrie force-pushed the commons-fixes-2403 branch from efc568a to 61705d9 Compare March 28, 2024 10:50
@delatrie delatrie force-pushed the specflow-fixes-2403 branch from d550de0 to 5ff0cc8 Compare March 28, 2024 10:54
@delatrie delatrie force-pushed the commons-fixes-2403 branch from 61705d9 to 0a561ad Compare March 28, 2024 13:20
@delatrie delatrie force-pushed the specflow-fixes-2403 branch from 5ff0cc8 to b988d0e Compare March 28, 2024 13:28
@delatrie delatrie changed the base branch from commons-fixes-2403 to main March 28, 2024 13:29
@delatrie delatrie marked this pull request as ready for review March 28, 2024 13:29
@delatrie delatrie requested a review from epszaw March 28, 2024 13:30
@delatrie delatrie force-pushed the specflow-fixes-2403 branch from b988d0e to dc34b99 Compare March 28, 2024 17:07
delatrie added 2 commits March 29, 2024 00:17
@delatrie
Update adapters table in README
dbc9b9c 
  - Change examples with documentation
  - Remove preview status badges
@delatrie
Update Xunit and NUnit readmes
eb26699 
  - Add namespace change note to Allure.NUnit
  - Fix [AllureNUnit]'s namespace
  - Add header and supported TFMs to Allure.Xunit
  - Fix supported SpecFlow versions
@delatrie delatrie merged commit fab3267 into main Mar 28, 2024
3 checks passed
@delatrie delatrie deleted the specflow-fixes-2403 branch March 28, 2024 21:30
@delatrie delatrie mentioned this pull request Mar 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epszaw epszaw epszaw approved these changes

Assignees

@delatrie delatrie

Labels
theme:build theme:core theme:nunit theme:specflow theme:workflow theme:xunit type:improvement
Projects
None yet
Milestone
No milestone
2 participants
@delatrie @epszaw