Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix no log for failed cases pytest-bdd (fixes #667) #668

Closed
wants to merge 3 commits into from
Closed

fix no log for failed cases pytest-bdd (fixes #667) #668

wants to merge 3 commits into from

Conversation

229max
Copy link
Contributor

@229max 229max commented Jun 29, 2022 •
edited
Loading

Context

add caplog for failed cases with pytest-bdd

#667

Checklist

@229max 229max changed the title fix no log for failed cases pytest-bdd fix no log for failed cases pytest-bdd (fixes #667) Jun 29, 2022
@229max 229max force-pushed the fix-pytest-bdd-no-failed-log branch from d2dc35b to d667553 Compare June 29, 2022 07:38
delatrie
delatrie requested changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@delatrie delatrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be implemented more in align with allure-pytest, i.e.:

  1. Attach not only caplog, but capstdout and capstderr as well.
  2. Attach always, not only on failures.

Also, the test is needed.

@delatrie
Copy link
Contributor

Implemented in #801

@delatrie delatrie closed this Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delatrie delatrie delatrie requested changes

Assignees
No one assigned
Labels
theme:pytest-bdd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@229max @delatrie @skhomuti