-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compatibility with pytest 8.1 #795
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhosyjhosy
approved these changes
Mar 4, 2024
Good finding and quick action. When is expected to be this released? I'm experiencing this error and just wondering if worth to downgrade pytest or waitining to to get the fix here. Thanks |
pytest 8.1 has been yanked (see pytest-dev/pytest#12069). We'll wait until the release becomes available again. |
skhomuti
approved these changes
Mar 5, 2024
https://docs.pytest.org/en/stable/changelog.html#pytest-8-1-0-2024-03-03 |
Out tests use pytest.Stash that requires pytest 7.0. We can't test against pytest 6 until the pytest version of the runner is decoupled with the one of the samples.
IvanBuruyane
pushed a commit
to IvanBuruyane/allure-python
that referenced
this pull request
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The
getfixturedefs
call must be fixed to adapt to the recent changes introduced in pytest-dev/pytest#11785 (pytest 8.1.0+).The changes are described here.
Note
The PR keeps the compatibility with older versions of pytest.
Fixes #794