Fix for newer kernels. (Tested on 6.11.x) #1
+6
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RealFX-Code Ive tryed installing your Fork, because its the one which claims the newest Kernel Compatibilty with 6.1.1, but it looks like it doesnt compile on 6.12.4 anymore (im on fedora 41). also looks like I know to little about low level stuff like this, to fix it for 6.12. can you maybe take look? sudo make test
make -C /lib/modules/6.12.4-200.fc41.x86_64/build M=/home/snoweuph/Downloads/macbook12-spi-driver/macbook12-spi-driver/macbook12-spi-driver/apple-touchbar-drv/macbook12-spi-driver/macbook12-spi-driver modules
make[1]: Verzeichnis „/usr/src/kernels/6.12.4-200.fc41.x86_64“ wird betreten
CC [M] /home/snoweuph/Downloads/macbook12-spi-driver/macbook12-spi-driver/macbook12-spi-driver/apple-touchbar-drv/macbook12-spi-driver/macbook12-spi-driver/apple-ibridge.o
/home/snoweuph/Downloads/macbook12-spi-driver/macbook12-spi-driver/macbook12-spi-driver/apple-touchbar-drv/macbook12-spi-driver/macbook12-spi-driver/apple-ibridge.c:192:6: Warnung: kein vorheriger Prototyp für »appleib_detach_and_free_hid_driver« [-Wmissing-prototypes]
192 | void appleib_detach_and_free_hid_driver(struct appleib_device *ib_dev,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/snoweuph/Downloads/macbook12-spi-driver/macbook12-spi-driver/macbook12-spi-driver/apple-touchbar-drv/macbook12-spi-driver/macbook12-spi-driver/apple-ibridge.c:752:25: Fehler: Initialisierung von »const __u8 * (*)(struct hid_device *, __u8 *, unsigned int *)« {alias »const unsigned char * (*)(struct hid_device *, unsigned char *, unsigned int *)«} von inkompatiblem Zeigertyp »__u8 * (*)(struct hid_device *, __u8 *, unsigned int *)« {alias »unsigned char * (*)(struct hid_device *, unsigned char *, unsigned int *)«} [-Wincompatible-pointer-types]
752 | .report_fixup = appleib_report_fixup,
| ^~~~~~~~~~~~~~~~~~~~
/home/snoweuph/Downloads/macbook12-spi-driver/macbook12-spi-driver/macbook12-spi-driver/apple-touchbar-drv/macbook12-spi-driver/macbook12-spi-driver/apple-ibridge.c:752:25: Anmerkung: (nahe der Initialisierung für »appleib_hid_driver.report_fixup«)
make[3]: *** [scripts/Makefile.build:229: /home/snoweuph/Downloads/macbook12-spi-driver/macbook12-spi-driver/macbook12-spi-driver/apple-touchbar-drv/macbook12-spi-driver/macbook12-spi-driver/apple-ibridge.o] Fehler 1
make[2]: *** [/usr/src/kernels/6.12.4-200.fc41.x86_64/Makefile:1976: /home/snoweuph/Downloads/macbook12-spi-driver/macbook12-spi-driver/macbook12-spi-driver/apple-touchbar-drv/macbook12-spi-driver/macbook12-spi-driver] Fehler 2
make[1]: *** [Makefile:236: __sub-make] Fehler 2
make[1]: Verzeichnis „/usr/src/kernels/6.12.4-200.fc41.x86_64“ wird verlassen
make: *** [Makefile:30: all] Fehler 2 |
This driver is wierd, I updated my gentoo system and it stopped compiling, iirc you can revert my two commits and it builds again. tip: if you want me to be able to read your logs, please make them english. |
Oh true, sry my bad. Without your two commits now: root@fedorabook-pro:/usr/src/applespi-0.1# LANG=en LLVM=1 make test
make -C /lib/modules/6.12.4-200.fc41.x86_64/build M=/usr/src/applespi-0.1 modules
make[1]: Entering directory '/usr/src/kernels/6.12.4-200.fc41.x86_64'
CC [M] /usr/src/applespi-0.1/apple-ibridge.o
/usr/src/applespi-0.1/apple-ibridge.c:192:6: warning: no previous prototype for function 'appleib_detach_and_free_hid_driver' [-Wmissing-prototypes]
192 | void appleib_detach_and_free_hid_driver(struct appleib_device *ib_dev,
| ^
/usr/src/applespi-0.1/apple-ibridge.c:192:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
192 | void appleib_detach_and_free_hid_driver(struct appleib_device *ib_dev,
| ^
| static
/usr/src/applespi-0.1/apple-ibridge.c:752:18: error: incompatible function pointer types initializing 'const __u8 *(*)(struct hid_device *, __u8 *, unsigned int *)' (aka 'const unsigned char *(*)(struct hid_device *, unsigned char *, unsigned int *)') with an expression of type '__u8 *(struct hid_device *, __u8 *, unsigned int *)' (aka 'unsigned char *(struct hid_device *, unsigned char *, unsigned int *)') [-Wincompatible-function-pointer-types]
752 | .report_fixup = appleib_report_fixup,
| ^~~~~~~~~~~~~~~~~~~~
/usr/src/applespi-0.1/apple-ibridge.c:901:3: error: field designator 'owner' does not refer to any field in type 'struct acpi_driver'
901 | .owner = THIS_MODULE,
| ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning and 2 errors generated.
make[3]: *** [scripts/Makefile.build:229: /usr/src/applespi-0.1/apple-ibridge.o] Error 1
make[2]: *** [/usr/src/kernels/6.12.4-200.fc41.x86_64/Makefile:1976: /usr/src/applespi-0.1] Error 2
make[1]: *** [Makefile:236: __sub-make] Error 2
make[1]: Leaving directory '/usr/src/kernels/6.12.4-200.fc41.x86_64'
make: *** [Makefile:30: all] Error 2
with them: root@fedorabook-pro:/usr/src/applespi-0.1# LANG=en LLVM=1 make test
make -C /lib/modules/6.12.4-200.fc41.x86_64/build M=/usr/src/applespi-0.1 modules
make[1]: Entering directory '/usr/src/kernels/6.12.4-200.fc41.x86_64'
CC [M] /usr/src/applespi-0.1/apple-ibridge.o
/usr/src/applespi-0.1/apple-ibridge.c:192:6: warning: no previous prototype for function 'appleib_detach_and_free_hid_driver' [-Wmissing-prototypes]
192 | void appleib_detach_and_free_hid_driver(struct appleib_device *ib_dev,
| ^
/usr/src/applespi-0.1/apple-ibridge.c:192:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
192 | void appleib_detach_and_free_hid_driver(struct appleib_device *ib_dev,
| ^
| static
/usr/src/applespi-0.1/apple-ibridge.c:752:18: error: incompatible function pointer types initializing 'const __u8 *(*)(struct hid_device *, __u8 *, unsigned int *)' (aka 'const unsigned char *(*)(struct hid_device *, unsigned char *, unsigned int *)') with an expression of type '__u8 *(struct hid_device *, __u8 *, unsigned int *)' (aka 'unsigned char *(struct hid_device *, unsigned char *, unsigned int *)') [-Wincompatible-function-pointer-types]
752 | .report_fixup = appleib_report_fixup,
| ^~~~~~~~~~~~~~~~~~~~
1 warning and 1 error generated.
make[3]: *** [scripts/Makefile.build:229: /usr/src/applespi-0.1/apple-ibridge.o] Error 1
make[2]: *** [/usr/src/kernels/6.12.4-200.fc41.x86_64/Makefile:1976: /usr/src/applespi-0.1] Error 2
make[1]: *** [Makefile:236: __sub-make] Error 2
make[1]: Leaving directory '/usr/src/kernels/6.12.4-200.fc41.x86_64'
make: *** [Makefile:30: all] Error 2both doesnt work, also I don really get the error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know of any compatibility issues, this patch works for me.