Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add User-Agent header on HTTP requests and WSS #254

Merged
merged 10 commits into from
Aug 21, 2023
Merged

Add User-Agent header on HTTP requests and WSS #254

merged 10 commits into from
Aug 21, 2023

Conversation

AlexandrosKyriakakis
Copy link
Member

Context

  • Adding User-Agent header on HTTP requests and WSS
  • Similar to alpaca-py

@AlexandrosKyriakakis AlexandrosKyriakakis self-assigned this Aug 2, 2023
gnvk
gnvk reviewed Aug 2, 2023
View reviewed changes
alpaca/version.go Outdated Show resolved Hide resolved
raja
raja requested changes Aug 2, 2023
View reviewed changes
marketdata/stream/conn_nhoory.go Outdated Show resolved Hide resolved
marketdata/rest.go Outdated Show resolved Hide resolved
leki75
leki75 reviewed Aug 2, 2023
View reviewed changes
Copy link
Contributor

@leki75 leki75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comments

alpaca/version.go Outdated Show resolved Hide resolved
alpaca/version.go Outdated Show resolved Hide resolved
alpaca/version.go Outdated Show resolved Hide resolved
marketdata/stream/conn_nhoory.go Outdated Show resolved Hide resolved
raja
raja reviewed Aug 3, 2023
View reviewed changes
alpaca/version.go Outdated Show resolved Hide resolved
@raja
Copy link

raja commented Aug 8, 2023

@AlexandrosKyriakakis going to address reviews?

@AlexandrosKyriakakis
Copy link
Member Author

Hey @raja, @leki75, thank you a lot for your reviews, it was super helpful!
Just addressed all the comments! Please have another look when you get a chance.

@raja
Copy link

raja commented Aug 16, 2023

^ @gnvk

gnvk
gnvk approved these changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@gnvk gnvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

leki75
leki75 approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@leki75 leki75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexandrosKyriakakis
Copy link
Member Author

Hey @raja I think I need also a re-review from you before merging.

@AlexandrosKyriakakis AlexandrosKyriakakis merged commit 5bbc587 into master Aug 21, 2023
3 checks passed
@AlexandrosKyriakakis AlexandrosKyriakakis deleted the add-user-agent-header branch August 21, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnvk gnvk gnvk approved these changes

@leki75 leki75 leki75 approved these changes

@raja raja raja approved these changes

@haxdds haxdds Awaiting requested review from haxdds

@sai-g sai-g Awaiting requested review from sai-g

@Neal Neal Awaiting requested review from Neal

Assignees

@AlexandrosKyriakakis AlexandrosKyriakakis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexandrosKyriakakis @raja @leki75 @gnvk