Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing AccountActivity and GetAccountActivitiesRequest fields #284

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Add missing AccountActivity and GetAccountActivitiesRequest fields #284

merged 2 commits into from
Jul 1, 2024

Conversation

gcatlin
Copy link
Contributor

@gcatlin gcatlin commented Jun 25, 2024 •
edited
Loading

GetAccountActivitiesRequest:

  • PageToken
  • Category

AccountActivity:

  • OrderID and OrderStatus (for FILL activities only) are documented
  • Status (for non-FILL activities) is not documented

@gcatlin gcatlin requested a review from gnvk as a code owner June 25, 2024 17:53
@gcatlin gcatlin changed the title Add missing AccountActivity fields: Status, OrderID, OrderStatus Add missing AccountActivity and GetAccountActivitiesRequest fields Jun 25, 2024
said-saifi
said-saifi approved these changes Jun 26, 2024
View reviewed changes
Copy link

@said-saifi said-saifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will update the docs.

alpaca/entities.go Show resolved Hide resolved
@gnvk gnvk merged commit 7d20c8f into alpacahq:master Jul 1, 2024
1 check passed
@gcatlin gcatlin deleted the activity-fields branch July 2, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@said-saifi said-saifi said-saifi approved these changes

@gnvk gnvk gnvk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gcatlin @gnvk @said-saifi