Add logging and optional callback to buffer fills #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slow client related issues: * `client.maintainConnection` waits for the `messageProcessor` goroutine(s) to finish to reconnect: this delays the reconnect and more messages will be missed * whenever the client buffer `c.in` is full the `connReader` goroutine is blocked
leki75
commented
Jul 22, 2024
alanvoss
reviewed
Jul 24, 2024
gnvk
reviewed
Aug 8, 2024
gnvk
reviewed
Aug 8, 2024
gnvk
reviewed
Aug 8, 2024
gnvk
reviewed
Aug 8, 2024
gnvk
changed the title
gnvk
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slow client related issues:
client.maintainConnectionwaits for themessageProcessorgoroutine(s) to finish to reconnect: this delays the reconnect and more messages can be missedc.inis full theconnReadergoroutine is blocked: the TCP stack of the operating system will buffer the messages and can cause disconnects if the application gets the pong message late, moreover theconnReadergoroutine will not exit if the context is cancelled while it is blocked on writing toc.in