Add option for installation #2476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychocoderHPC
requested changes
Feb 10, 2025
CMakeLists.txt
Outdated
| @@ -162,8 +162,9 @@ endif() | |||
| ################################################################################ | |||
| # Installation. | |||
|
|
|||
| option(alpaka_INSTALL "" OFF) | |||
There was a problem hiding this comment.
please add a short doc instead of "" e.g.
allow installation of alpaka if used as project dependency
There was a problem hiding this comment.
please add this option additionally to our documentation: https://github.com/alpaka-group/alpaka/blob/develop/docs/source/advanced/cmake.rst
psychocoderHPC
approved these changes
Feb 10, 2025
|
Jobs are failing with Please, restart! |
|
@psychocoderHPC We're down to two failing runners: https://gitlab.com/hzdr/crp/alpaka/-/pipelines/1664050946/failures Please restart! |
psychocoderHPC
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to install alpaka as part of another project if configured and export its targets into that installation.
Also fixes a bug:
target_include_directorieswas given an absolute path (_alpaka_INCLUDE_DIRECTORYis absolute) to the source directory which meant that dependents always used the headers directly from the source directory if they were using thealpaka::alpakatarget directly. That was never a problem if dependents were applications that didn't expose alpaka headers themselves or the final application to be built used alpaka itself (leading to basically the same situation). But if you try to install a library L that depends on alpaka and a user of the library tries to use L from the installation without using alpaka directly, it needs to find alpaka's headers and they are located in the source directory (which might have been removed already), not in the installation directory.