Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix few bugs #253

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

psychocoderHPC
Copy link
Member

  • fix double page clean-up()` was not taken into account
  • fix that the page lock during `tryUsePage

@chillenzer could you please have a look if you observe any logical issues.

@psychocoderHPC psychocoderHPC added this to the 2.6.0crp milestone Jun 17, 2024
Copy link
Contributor

@chillenzer chillenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me. In contrast to my version, you've only got 2 calls to tryCleanPage when it's 4 in my case. One of them is when trying out pages. Because you never "enter" a page (increasing filling level) while searching around, you don't take responsibility for cleaning up. The other one is the multi-page mode which does this by hand.

Apart form that, the structure seems to be very similar.

@psychocoderHPC
Copy link
Member Author

Looks okay to me. In contrast to my version, you've only got 2 calls to tryCleanPage when it's 4 in my case. One of them is when trying out pages. Because you never "enter" a page (increasing filling level) while searching around, you don't take responsibility for cleaning up. The other one is the multi-page mode which does this by hand.

Apart form that, the structure seems to be very similar.

I will check tomorrow for the cases where the full page is used. Since in this implementation chunksize is checked before increasing the fill level the number of calls to try clean can differ.

@psychocoderHPC
Copy link
Member Author

I checked if tryCleanPage is called where it should The multi page allocation for large chunks is not using the fill level. It uses the chunksize only therefore tryCleanPage is not required.

- fix double page clean-up()` was not taken into account
- fix that the page lock during `tryUsePage
@psychocoderHPC psychocoderHPC merged commit 8b74df7 into alpaka-group:dev Aug 7, 2024
1 check passed
@psychocoderHPC psychocoderHPC deleted the fix-dublicatedFree branch August 7, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants