Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gem_layout_full_width_browse_header for Browse pages #3245

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

patrickpatrickpatrick
Copy link
Contributor

@patrickpatrickpatrick patrickpatrickpatrick commented May 4, 2023

What

Use new gem_layout_full_width_browse template for Browse pages. Remove blue bar from browse_breadcrumbs partial.

Why

There are instances of pages on collections that have a coloured background in the heading section. This meant that the the blue bar (which is rendered in the public_layout) had to be rendered by collections otherwise it would result in a gap between the blue bar and coloured section. This solution seemed fine until we had a recent deployment of the global bar. As the global bar includes a blue bar, it meant that the Browse pages had two blue bars. They therefore needed to be removed while the global bar was present and then added back again when the global bar was removed.

To avoid this needing to happen the next time the bar is deployed, a new template has been implemented. It means that if a page has a coloured background heading it can be specified in the template and then it will be applied to the blue bar. This means the blue bar can be rendered in public_layout and so applications don't need to render the blue bar if they have a heading section with a background colour.

To accomplish this in collections, we need to change the template to the new gem_layout_full_width_browse_header and remove the blue bar from the breadcrumbs partial.

Follow these steps if you are doing a Rails upgrade.

Relevant Trello Card

@govuk-ci govuk-ci temporarily deployed to collections-pr-3245 May 4, 2023 14:37 Inactive
@patrickpatrickpatrick patrickpatrickpatrick changed the title No blue bar when no global bar Use gem_layout_full_width_browse_header for Browse pages May 11, 2023
@patrickpatrickpatrick
Copy link
Contributor Author

@jon-kirwan jon-kirwan self-requested a review June 13, 2023 10:30
Copy link
Contributor

@jon-kirwan jon-kirwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me 👍

@patrickpatrickpatrick patrickpatrickpatrick marked this pull request as ready for review August 25, 2023 09:37
@patrickpatrickpatrick patrickpatrickpatrick marked this pull request as draft August 25, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants