Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use govuk-ruby-images and remove disused config files. #1243

Merged
merged 4 commits into from
Feb 22, 2024
Merged

Use govuk-ruby-images and remove disused config files. #1243

merged 4 commits into from
Feb 22, 2024

Conversation

sengi
Copy link
Contributor

@sengi sengi commented Feb 15, 2024 •
edited
Loading

Essentially the same thing for Publish as alphagov/datagovuk_find#1198 for Find.

  • Delete disused config files for CloudFoundry and earlier hosting.
  • Refactor Dockerfile to use govuk-ruby-images. This gives us a bunch of stuff for free, such as:
    • jemalloc (more consistent memory usage, which helps in production)
    • common packages preinstalled so less boilerplate
    • two-stage build so output image is smaller with no leftover cruft from the build
    • Ruby and other system dependencies are always patched up to date

sengi added 4 commits February 15, 2024 21:25
@sengi
Delete disused config files.
d46752e 
Publish no longer runs on CloudFoundry.
@sengi
Add .dockerignore to make local builds more robust.
2b56174
@sengi
Use govuk-ruby-images and refactor Dockerfile.
697267b 
- Use govuk-ruby-base/builder images so we get the Ruby tmpdir
  workaround, jemalloc, preinstalled common packages, faster builds etc.
- Two-stage build so we don't include build cruft in the final image.
- Add OCI source label.
- Don't defeat data deletion prevention features by default. Set them in
  dev k8s manifests or Docker Compose or whatever.
@sengi
Avoid pinning the Ruby "tiny" (patch) version.
fa52ef4 
We want to be on the latest patch version by default.

The Gemfile.lock changes were generated by `bundle install`.
@sengi sengi marked this pull request as ready for review February 16, 2024 14:05
@sengi sengi requested a review from kentsanggds February 16, 2024 14:07
@kentsanggds kentsanggds merged commit fa52ef4 into main Feb 22, 2024
4 checks passed
@kentsanggds kentsanggds deleted the sengi/base-image branch February 22, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsimpson1 samsimpson1 samsimpson1 approved these changes

@kentsanggds kentsanggds Awaiting requested review from kentsanggds

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sengi @samsimpson1 @kentsanggds