Update sidekiq.yaml #1257
Merged
Update sidekiq.yaml #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Publish no longer runs on CloudFoundry.
- Use govuk-ruby-base/builder images so we get the Ruby tmpdir workaround, jemalloc, preinstalled common packages, faster builds etc. - Two-stage build so we don't include build cruft in the final image. - Add OCI source label. - Don't defeat data deletion prevention features by default. Set them in dev k8s manifests or Docker Compose or whatever.
We want to be on the latest patch version by default. The Gemfile.lock changes were generated by `bundle install`.
sengi
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
schedulekey is now nested underschedulerkey, so update the sidekiq.yamlAlso pulls in other approved PRs for dependency updates and the refactoring of the Dockerfile