Merge pull request #464 from alphagov/allow-archived-forms-to-be-made…

…-live

Allow archived forms to be made live

app/state_machines/form_state_machine.rb

@@ -34,7 +34,7 @@ module FormStateMachine
           made_live_forms.create!(json_form_blob: form_blob.to_json, created_at: live_at)
         end
 
-        transitions from: %i[draft live_with_draft], to: :live, guard: proc { ready_for_live }
+        transitions from: %i[draft live_with_draft archived archived_with_draft], to: :live, guard: proc { ready_for_live }
       end
 
       event :create_draft_from_live_form do

spec/state_machines/form_state_machine_spec.rb

@@ -50,6 +50,30 @@ class FakeForm < Form
         it_behaves_like "transition to live state", FakeForm, :live_with_draft
       end
     end
+
+    context "when form is archived" do
+      let(:form) { FakeForm.new(state: :archived) }
+
+      it "does not transition to live state by default" do
+        expect(form).not_to transition_from(:archived).to(:live).on_event(:make_live)
+      end
+
+      context "when all sections are completed" do
+        it_behaves_like "transition to live state", FakeForm, :archived
+      end
+    end
+
+    context "when form is archived_with_draft" do
+      let(:form) { FakeForm.new(state: :archived_with_draft) }
+
+      it "does not transition to live state by default" do
+        expect(form).not_to transition_from(:archived_with_draft).to(:live).on_event(:make_live)
+      end
+
+      context "when all sections are completed" do
+        it_behaves_like "transition to live state", FakeForm, :archived_with_draft
+      end
+    end
   end
 
   describe ".create_draft_from_live_form" do