Convert what happens next content to markdown #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidBiddle
force-pushed
the
convert-whn-to-markdown
branch
from
64d4a9b to
0006406
Compare
DavidBiddle
changed the title
Adds the ReverseMarkdown gem to the app, so that we can automatically convert the what_happens_next_text content into markdown.
DavidBiddle
force-pushed
the
convert-whn-to-markdown
branch
2 times, most recently
from
8021f17 to
253fe03
Compare
Adds a rake task which uses the ReverseMarkdown gem to convert each form and made_live_form's what_happens_next_text content to markdown, and save this markdown to the what_happens_next_markdown field. Also adds a task to clear the content in the what_happens_next_markdown field in case we need to revert the change.
DavidBiddle
force-pushed
the
convert-whn-to-markdown
branch
from
275e750 to
f532286
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
aliuk2012
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/AbPj2LRr/1191-allow-markdown-on-confirmation-page-what-happens-next-content
Adds a rake task which takes the content of the what_happens_next_text field, converts it to markdown using the ReverseMarkdown gem, then saves this markdown in the to the what_happens_next_markdown field that we added in #371. It also adds this markdown to the made live form.
Doing this as a rake task means we're not stuck with a migration that's dependent on a specific gem, and we've previously said we'd consider reserving migrations for schema changes. The downside is we'll have to run the task manually in each environment.
To do in other PRs:
Things to consider when reviewing