Add favicon.ico to server root #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're seeing a lot of `404`s in our server logs from clients trying to reach `/favicon.ico`. This commit hopefully fixes this by making it so we can serve the favicon from that path.
lfdebrux
force-pushed
the
ldeb-add-root-favicon
branch
from
fc4c3b4 to
56f8d53
Compare
|
thomasiles
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/j3LGb3mn/1375-blocked-on-tudor-crown-investigate-favicon-404-errors-in-production
We're seeing a lot of
404s in our server logs from clients trying to reach/favicon.ico. This commit hopefully fixes this by making it so we can serve the favicon from that path.Things to consider when reviewing