Merge pull request #3930 from alphagov/2314-remove-the-ab-test-on-the…

…-homepage Remove the AB test on the homepage
alphagov · Jan 18, 2024 · deeb15f · deeb15f
2 parents 66874f1 + 449ebd3
commit deeb15f
Show file tree

Hide file tree

Showing 7 changed files with 2 additions and 145 deletions.
diff --git a/app/controllers/concerns/homepage_popular_links_ab_testable.rb b/app/controllers/concerns/homepage_popular_links_ab_testable.rb
diff --git a/app/controllers/homepage_controller.rb b/app/controllers/homepage_controller.rb
@@ -1,7 +1,5 @@
 class HomepageController < ContentItemsController
   include Cacheable
-  include HomepagePopularLinksAbTestable
-
   slimmer_template "gem_layout_homepage"
 
   def index

diff --git a/app/views/homepage/_popular_links.html.erb b/app/views/homepage/_popular_links.html.erb
@@ -2,16 +2,6 @@
   add_view_stylesheet("popular_links")
 %>
 
-<% if variant_b_page? %>
-  <% popular_links = t("homepage.index.popular_links_b") %>
-<% elsif variant_c_page? %>
-  <% popular_links = t("homepage.index.popular_links_c") %>
-<% elsif variant_d_page? %>
-  <% popular_links = t("homepage.index.popular_links_d") %>
-<% else %>
-  <% popular_links = t("homepage.index.popular_links") %>
-<% end %>
-
 <section class="homepage-section homepage-section__popular-links">
   <div class="govuk-width-container">
     <div class="govuk-grid-row">
@@ -22,7 +12,7 @@
           text: t("homepage.index.popular_links_heading"),
         } %>
         <ul class="homepage-most-viewed-list" data-module="gem-track-click ga4-link-tracker">
-          <% popular_links.each_with_index do | item, index | %>
+          <% t("homepage.index.popular_links").each_with_index do | item, index | %>
             <li class="homepage-most-viewed-list__item">
               <%= render "govuk_publishing_components/components/action_link", {
                 text: item[:text],
@@ -41,7 +31,7 @@
                     'index_section': locals[:index_section],
                     'index_link': index + 1,
                     'index_section_count': locals[:index_section_count],
-                    'index_total': popular_links.length,
+                    'index_total': t("homepage.index.popular_links").length,
                     'section': "#{t("homepage.index.popular_links_heading", locale: :en)}"
                   }
                 }

diff --git a/app/views/homepage/index.html.erb b/app/views/homepage/index.html.erb
@@ -1,6 +1,5 @@
 <% add_view_stylesheet("homepage")%>
 <% content_for :extra_headers do %>
-  <%= homepage_popular_links_ab_test_variant.analytics_meta_tag.html_safe if page_under_test? %>
   <link rel="canonical" href="<%=  Frontend.govuk_website_root + root_path %>">
   <meta name="description" content="<%= t("homepage.index.meta_description_new") %>">
 <% end %>

diff --git a/config/locales/cy.yml b/config/locales/cy.yml
@@ -931,9 +931,6 @@ cy:
       more:
       popular_links_heading:
       popular_links:
-      popular_links_b:
-      popular_links_c:
-      popular_links_d:
       more_links:
       other_agencies:
       other_agencies_count:

diff --git a/config/locales/en.yml b/config/locales/en.yml
@@ -581,45 +581,6 @@ en:
           href: /check-national-insurance-record
         - text: 'Check MOT history of a vehicle'
           href: /check-mot-history
-      popular_links_b:
-        - text: 'Universal Credit account: sign in'
-          href: /sign-in-universal-credit
-        - text: 'Check MOT history of a vehicle'
-          href: /check-mot-history
-        - text: 'HMRC online services: sign in or set up an account'
-          href: /log-in-register-hmrc-online-services
-        - text: 'Get information about a company'
-          href: /get-information-about-a-company
-        - text: 'Tax your vehicle'
-          href: /vehicle-tax
-        - text: 'Check if a vehicle is taxed'
-          href: /check-vehicle-tax
-      popular_links_c:
-        - text: 'HMRC online services: sign in or set up an account'
-          href: /log-in-register-hmrc-online-services
-        - text: 'Check your State Pension forecast'
-          href: /check-state-pension
-        - text: 'Personal tax account: sign in or set up'
-          href: /personal-tax-account
-        - text: 'Sign in to your childcare account'
-          href: /sign-in-childcare-account
-        - text: 'File your Self Assessment tax return online'
-          href: /log-in-file-self-assessment-tax-return
-        - text: 'Universal Credit account: sign in'
-          href: /sign-in-universal-credit
-      popular_links_d:
-        - text: 'Change your driving test appointment'
-          href: /change-driving-test
-        - text: 'Book your driving test'
-          href: /book-driving-test
-        - text: 'Universal Credit account: sign in'
-          href: /sign-in-universal-credit
-        - text: 'HMRC online services: sign in or set up an account'
-          href: /log-in-register-hmrc-online-services
-        - text: 'Find an energy certificate'
-          href: /find-energy-certificate
-        - text: 'Student finance login'
-          href: /student-finance-register-login
       # If adding or removing items remember to update the `columns()` mixin in
       # the homepage-most-active-list class in _homepage.scss.
       more_links:

diff --git a/test/integration/homepage_test.rb b/test/integration/homepage_test.rb
@@ -1,8 +1,6 @@
 require "integration_test_helper"
 
 class HomepageTest < ActionDispatch::IntegrationTest
-  include GovukAbTesting::MinitestHelpers
-
   setup do
     stub_content_store_has_item("/", schema: "special_route")
   end
@@ -41,41 +39,4 @@ class HomepageTest < ActionDispatch::IntegrationTest
       assert page.has_content?(I18n.t("homepage.index.government_activity_description", locale: :en))
     end
   end
-
-  context "when AB testing different popular links" do
-    should "have different links for the B variant" do
-      with_variant HomepagePopularLinksTest: "B" do
-        visit "/"
-        assert page.has_text?("Get information about a company")
-      end
-    end
-
-    should "have different links for the A variant" do
-      with_variant HomepagePopularLinksTest: "A" do
-        visit "/"
-        assert page.has_text?("Find out about help you can get with your energy bills")
-      end
-    end
-
-    should "have different links for the Z variant" do
-      with_variant HomepagePopularLinksTest: "Z" do
-        visit "/"
-        assert page.has_text?("Find out about help you can get with your energy bills")
-      end
-    end
-
-    should "have different links for the C variant" do
-      with_variant HomepagePopularLinksTest: "C" do
-        visit "/"
-        assert page.has_text?("Sign in to your childcare account")
-      end
-    end
-
-    should "have different links for the D variant" do
-      with_variant HomepagePopularLinksTest: "D" do
-        visit "/"
-        assert page.has_text?("Find an energy certificate")
-      end
-    end
-  end
 end