Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix video tracking on AB test #3931

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Fix video tracking on AB test #3931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions app/views/transaction/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,10 @@
margin_bottom: true,
data_attributes: data_attributes %>
<% if hmrc_temporary_ab_test_variant_b? %>
<div class="govuk-body govuk-!-padding-bottom-5">
<%= "#{t('ab_testing.ready_reckoner_video_test_html')}".html_safe %>
</div>
<%= render "govuk_publishing_components/components/govspeak", {} do %>
<p><%= t('ab_testing.ready_reckoner_video_description') %></p>
<p><a href="https://www.youtube.com/watch?v=xHn31myAkio">How do I budget for my Self Assessment tax bill?</a></p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just wondering if we should put the href and link title in the locale file as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good shout, will look into.

<% end %>
<% end %>
</p>
</section>
Expand Down
2 changes: 1 addition & 1 deletion config/locales/cy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ cy:
two_versions: Mae 2 fersiwn o'r dudalen hon. Rydych chi'n gweld y
version: fersiwn
visit_govuk_html: Ewch i <a href="/" class="govuk-link">hafan GOV.UK</a> i weld gwasanaethau a gwybodaeth y llywodraeth.
ready_reckoner_video_test_html:
ready_reckoner_video_description:
account:
cookies_and_feedback:
cookie_consent:
Expand Down
2 changes: 1 addition & 1 deletion config/locales/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ en:
two_versions: There are 2 versions of this page. You are viewing the
version: version
visit_govuk_html: Visit the <a href="/" class="govuk-link">GOV.UK homepage</a> to find government services and information.
ready_reckoner_video_test_html: <div class="gem-c-image-card gem-c-image-card--large" data-module="image-card" data-image-card-module-started="true"><div class="gem-c-image-card__text-wrapper"><div class="gem-c-image-card__header-and-context-wrapper"></div><div class="gem-c-image-card__description">Watch this video to find out how a budget payment plan can help you pay your tax bill on time.</div><figure class="gem-c-image-card__image-wrapper gem-c-image-card__image-wrapper--youtube-embed"><div class="gem-c-govspeak__youtube-video gem-c-image-card__youtube-video-embed"><iframe id="youtube-1" data-video-id="xHn31myAkio" frameborder="0" allowfullscreen="" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture; web-share" title="How to use a budget payment plan to pay your tax bill online video on YouTube (video)" width="640" height="360" src="https://www.youtube-nocookie.com/embed/xHn31myAkio?enablejsapi=1&amp;origin=http%3A%2F%2F127.0.0.1%3A3090&amp;rel=0&amp;disablekb=1&amp;modestbranding=1&amp;channel&amp;widgetid=1"></iframe></div></figure></div>
ready_reckoner_video_description: Watch this video to find out how a budget payment plan can help you pay your tax bill on time.
account:
cookies_and_feedback:
cookie_consent:
Expand Down
Loading