Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV previews are sometimes broken #3945

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

unoduetre
Copy link
Contributor

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

What

We have had issues with CSV previews for some time, and work has been done to resolve them. However they seem to be occurring again (see Examples below). The purpose of this card is to investigate what’s going wrong and suggest a fix.

Examples

Why

Trello card

Screenshots?

No user-visible changes.

@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-3945 January 29, 2024 15:17 Inactive
@unoduetre unoduetre force-pushed the 2328-csv-previews-are-sometimes-broken-l-1 branch from dfdda16 to 987465c Compare January 29, 2024 15:29
@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-3945 January 29, 2024 15:30 Inactive
@unoduetre unoduetre marked this pull request as ready for review January 29, 2024 15:42
@hannako
Copy link
Contributor

hannako commented Jan 29, 2024

Thanks Mat, this is great, and I agree with your comment in the trello card about work to limit the number of lines sent from asset manager.

I feel like this controller is now a bit out of hand though - it's become so bloated. We could either refactor here or if you prefer, we could merge this work and then refactor in a fresh PR?

@unoduetre
Copy link
Contributor Author

unoduetre commented Jan 29, 2024

As discussed, let's merge it, so we can make sure the problem is resolved and then do the refactoring as a separate PR.

Copy link
Contributor

@hannako hannako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Mat 🥇

@unoduetre
Copy link
Contributor Author

Gonna merge tomorrow morning.

@unoduetre unoduetre merged commit 9a91477 into main Jan 30, 2024
13 checks passed
@unoduetre unoduetre deleted the 2328-csv-previews-are-sometimes-broken-l-1 branch January 30, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants