bumped bosh-aws-cpi-release 99->101 to support new aws vm type disks #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackjoy-gds
force-pushed
the
186260603-support_new_aws_vm_type_disks
branch
2 times, most recently
from
dbbd364 to
c3343e5
Compare
corlettb
reviewed
Dec 28, 2023
| version: "99" | ||
| url: "https://bosh.io/d/github.com/cloudfoundry/bosh-aws-cpi-release?v=99" | ||
| sha1: "ffc4a06d6728d88eb108418f886f46428c2a1bf2" | ||
| version: "101" |
There was a problem hiding this comment.
You missed the comment above this section where it tells you to update the https://github.com/alphagov/paas-docker-cloudfoundry-tools/blob/main/bosh-cli-v2/Dockerfile file first.
Should we put in an # IMPORTANT!! there to make it more obvious?
jackjoy-gds
force-pushed
the
186260603-support_new_aws_vm_type_disks
branch
from
c3343e5 to
30c2481
Compare
corlettb
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
bumped bosh-aws-cpi-release 99->101 to support new aws vm type disks
How to review
Either deploy to your own dev env or look at mine on dev04
Who can review
Any paas-dev
🚨⚠️ Please do not merge this pull request via the GitHub UI ⚠️ 🚨