Make migrations concurrent #3113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yndajas
approved these changes
Jan 30, 2025
The migrations to add new indexes were previously locking all writes to the editions table at the time of running. As one of the migrations is slow (several minutes), this caused degraded performance of the application. Making them concurrent to remove the need for the tables to be locked. Concurrent indexes must be created outside of a transaction [1]. 1: https://thoughtbot.com/blog/how-to-create-postgres-indexes-concurrently-in
brucebolt
force-pushed
the
make-migrations-concurrent
branch
from
9ece577 to
f7f1635
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The migrations to add new indexes were previously locking all writes to the editions table at the time of running.
As one of the migrations is slow (several minutes), this caused degraded performance of the application.
Making them concurrent to remove the need for the tables to be locked.
Trello card