(866) Add a pension content block #3120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new `Pension` content block - this introduces a new concept
of a block that has “embedded” objects. These objects MUST always have
a title, the key of which is derived from the object’s title. I’ve made
a Jsonnet util to support this, so we don’t have to repeat ourselves
each time an embedded object is introduced. For example, the `details`
of a simple pension block will look like this:
```
{
"description": "Description goes here",
"rates" :{
"rate-1" :{
"name": "Rate 1",
"amount": "221.20",
"cadence": "weekly",
"description": "Your weekly pension amount"
}
}
}
```
It also introduces a non-standard `order` attribute. As we need to
ensure all embedded objects have a `name`, we have to merge the
`properties` together with an object including `name`. This doesn’t
preserve the order, so we keep have this additional field that we can
then use in the Content Block Manager frontend to ensure the attributes
appear in the order we specify, with the `name` as the first attribute.
Harriethw
approved these changes
Feb 4, 2025
pezholio
deleted the
content-modelling/866-add-pension-model-to-publishing-api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
Pensioncontent block - this introduces a new concept of a block that has “embedded” objects. These objects MUST always have a title, the key of which is derived from the object’s title. I’ve made a Jsonnet util to support this, so we don’t have to repeat ourselves each time an embedded object is introduced. For example, thedetailsof a simple pension block will look like this:It also introduces a non-standard
orderattribute. As we need to ensure all embedded objects have aname, we have to merge thepropertiestogether with an object includingname. This doesn’t preserve the order, so we keep have this additional field that we can then use in the Content Block Manager frontend to ensure the attributes appear in the order we specify, with thenameas the first attribute.