Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add govuk web banners gem #6966

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Add govuk web banners gem #6966

merged 2 commits into from
Dec 10, 2024

Conversation

KludgeKML
Copy link
Contributor

Remove internal banner handling code/config for recruitment banners and replace with govuk_web_banners

https://trello.com/c/aYXKcrCo/375-create-govukwebbanner-gem-with-support-for-recruitment-banners

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

@govuk-ci govuk-ci temporarily deployed to smart-answers-pr-6966 November 27, 2024 16:49 Inactive
@KludgeKML KludgeKML force-pushed the add-govuk_web_banners-gem branch from c9f13fe to bf5b737 Compare November 27, 2024 20:32
@govuk-ci govuk-ci temporarily deployed to smart-answers-pr-6966 November 27, 2024 20:33 Inactive
@KludgeKML KludgeKML requested a review from leenagupte November 27, 2024 20:36
Copy link
Contributor

@leenagupte leenagupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One file removal has been missed, otherwise it looks good.

lib/data/recruitment_banners.yml Show resolved Hide resolved
- add recruitment banners tag between breadcrumbs and main element
@KludgeKML KludgeKML force-pushed the add-govuk_web_banners-gem branch from bf5b737 to 6055837 Compare December 2, 2024 10:46
@govuk-ci govuk-ci temporarily deployed to smart-answers-pr-6966 December 2, 2024 10:46 Inactive
@KludgeKML KludgeKML requested a review from leenagupte December 10, 2024 14:04
@KludgeKML KludgeKML merged commit b96ce54 into main Dec 10, 2024
12 checks passed
@KludgeKML KludgeKML deleted the add-govuk_web_banners-gem branch December 10, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants