-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Number.parseInt(offset, 10) not a function #50
Comments
Switching to the global isNaN and global parseInt from the Number one fixes my problem. I have a PR here. |
@Syzygy24 what version of phantomJS are you using? we can do https://github.com/alphasights/ember-scrollable/blob/master/package.json#L48 extra debugginghttps://github.com/babel/ember-cli-babel/blob/v5.1.6/index.js#L41 https://github.com/babel/ember-cli-babel/blob/v5.1.6/package.json#L24 https://github.com/babel/broccoli-babel-transpiler/blob/v5.4.5/package.json#L31 https://github.com/zloirock/core-js/blob/v1.0.0/library/index.js https://github.com/zloirock/core-js/blob/v1.0.0/library/shim.js#L19 |
I'm on phantom 2.1.1 |
I'm running into this now too, any ideas on a fix/workaround? |
@offirgolan we can merge #51 or downstream people can do the babel polyfill fix above for testing. I'm not sure what the attitude is for Ember & addons w.r.t browser compatability. |
I'm a noob, after some more digging I got the polyfill working fine. If anyone else is looking for a solution to this just put the following in your
Obviously this could still be fixed via the PR but FWIW I'm totally fine with the polyfill solution. |
I'm using your module through ember-light-table, and I'm getting this error when testing through phantomjs: "TypeError: undefined is not a function (evaluating 'Number.parseInt(offset, 10)')", at the function call here.
I'm not sure what would cause Number.parseInt() to be undefined.
The text was updated successfully, but these errors were encountered: