Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: include Babel polyfill #68

Closed
wants to merge 1 commit into from

Conversation

buschtoens
Copy link
Contributor

Resolves IE freezing mentioned in #67

Resolves IE freezing mentioned in alphasights#67
@alexander-alvarez
Copy link
Contributor

relates to #51 no?

@buschtoens
Copy link
Contributor Author

Not really. The ember-cli-build.js file only affects the build of the addon dummy app.

We could force the polyfill inclusion via the included hook, but I consider that bad practice. We should probably add a note to the readme though.

@alexander-alvarez
Copy link
Contributor

alexander-alvarez commented Mar 28, 2017

i'm pretty sure #50 is the only non IE. functionality in ember-scrollable, do you think there's something else that requires the pollyfills for compatibility?

@buschtoens
Copy link
Contributor Author

I believe it's the only thing. In my case it doesn't really matter as we include the polyfill anyways, as we use other ES6 features in our app as well. The polyfill and regenerator runtime add about 28 k gzipped, possibly less.

I can understand that some folks would not want to add this (arguably small) added weight for an addon that could easily avoid this.

While I'd rather stay true to ES6 all the way, I have no objections against including the inline safety net (#50 (comment)) or a one line polyfill.

@buschtoens
Copy link
Contributor Author

Superseded by #69.

@buschtoens buschtoens closed this Mar 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants