Update the fallback branch #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alphp#15 Fix fatal error with non-Gregorian locales
* master: Tests: use assertThat instead assertMatchesRegularExpression Fix tests: PHP-7.4 on Windows Fix tests: PHP-7.4 on Windows Fix tests Fix test Action: add Windows and macOS test Fix test locale eu Fix test with PHP-8.3 Actions: update checkout and cache Test only on ubuntu-latest Test on matrix Fix fatal error when using the default PHP locale alphp#17 Code review tweaks alphp#15 Fix fatal error with non-Gregorian locales
In phpunit 10 expectNotice is no longer available. This converts the notice into an ErrorException and tests for that.
When intl isn't available, we don't really care about the locale anyway, since only english results are returned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges master into fallback-intl, makes some needed adjustments and fixes test compatibility with PHPUnit 10