tidy up changes from previous commit

.github/workflows/go-build.yml

@@ -5,6 +5,8 @@ on:
     branches:
       - 'master'
       - 'test/**'
+    paths:
+      - 'VERSION'
 
 permissions:
   contents: write

pinnacle.go

@@ -71,7 +71,6 @@ func (p *Pinnacle) cleanup(ctx context.Context, err error) {
 	if err == nil {
 		return
 	}
-	p.CaptureErr(ctx, err)
 	p.CaptureErr(ctx, ui.DisplayError(ctx, err, p.logFile))
 	p.CaptureErr(ctx, os.RemoveAll(p.alpinePath("launcher.jar")))
 	p.CaptureErr(ctx, os.RemoveAll(p.alpinePath("jre", "17")))

ui/error.go

@@ -4,7 +4,6 @@ import (
 	"context"
 	"errors"
 	"io"
-	"log"
 	"os"
 	"os/exec"
 	"runtime"
@@ -27,23 +26,17 @@ func DisplayError(ctx context.Context, err error, logFile *os.File) error {
 
 	var logContent string
 	if logFile != nil {
-		logFile.Close()
-		log.Println("reading log file again at: " + logFile.Name())
-		logFileToRead, lerr := os.Open(logFile.Name())
-		if lerr != nil {
-			log.Printf("error opening log file %q: %v", logFile.Name(), lerr)
-		} else {
-			defer logFileToRead.Close()
-			logData, rerr := io.ReadAll(logFileToRead)
-			if rerr != nil {
-				log.Println(errors.Unwrap(rerr))
-			} else {
-				log.Println("attaching log file to sentry report")
+		_ = logFile.Close()
+		logFileToRead, ler := os.Open(logFile.Name())
+		if ler == nil {
+			defer func() {
+				_ = logFileToRead.Close()
+			}()
+			logData, rer := io.ReadAll(logFileToRead)
+			if rer == nil {
 				logContent = string(logData)
-				log.Printf("length of log: %d\n", len(logContent))
 			}
 		}
-
 	}
 
 	id := sentry.CaptureErr(ctx, err, logContent)

ui/notify.go

@@ -13,6 +13,6 @@ const (
 func NotifyNewUpdate() {
 	const msg = "Update available!\n\nPlease visit " + downloadURL
 
-	log.Printf("[INFO] %s", msg)
+	log.Println(msg)
 	_ = zenity.Notify(msg, zenity.Title(WindowTitle))
 }

ui/ui.go

@@ -68,7 +68,7 @@ func Render() {
 		zenity.Height(uint(WindowHeight)),
 	)
 	if err != nil {
-		log.Printf("[ERROR] failed to render progress bar: %v", err)
+		log.Printf("[ERROR] failed to render progress bar: %v\n", err)
 		dialog = nil
 	}
 }