Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Don't delete helm plugins dir after install #45

Closed
wants to merge 2 commits into from
Closed

Fix: Don't delete helm plugins dir after install #45

wants to merge 2 commits into from

Conversation

Angelin01
Copy link
Contributor

Stop deleting /root/.local after plugin install, as Helm plugins are installed to ~/.local/share/helm/plugins.

Fixes #44

@Angelin01
fix: Don't delete helm plugins dir after install
5b9b838
@Angelin01
fix: Delete test data for helm-push
2af7e1d 
This avoids issues with commercial security scanners.
Also further reduces image size.
@Angelin01
Copy link
Contributor Author

I've pushed a new commit which deletes helm-push's testdata folder to address the issue raised by @johnswarbrick-napier:
#44 (comment)

@ozbillwang
Copy link
Collaborator

ozbillwang commented Jan 18, 2023 •
edited
Loading

thanks for the PR. I did it via #47

(1) rollback to change #40
(2) clean the testdata folders for helm-push

@ozbillwang ozbillwang closed this Jan 18, 2023
@ozbillwang
Copy link
Collaborator

images are updated, please check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm plugins are no longer installed
2 participants
@Angelin01 @ozbillwang