Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digital Bookshelf V2 #2866

Merged
merged 19 commits into from
Feb 28, 2025
Merged

Digital Bookshelf V2 #2866

merged 19 commits into from
Feb 28, 2025

Conversation

george-gca
Copy link
Collaborator

Since I was annoyed at not being able to use jekyll-archives to create an archive for the books, I decided to implement myself the jekyll-archives-v2 that doesn't have this limitation.

Closes #923.

Copy link

netlify bot commented Nov 30, 2024

Deploy Preview for relaxed-lollipop-b6bc17 ready!

Name Link
🔨 Latest commit b8b9202
🔍 Latest deploy log https://app.netlify.com/sites/relaxed-lollipop-b6bc17/deploys/67c1e9a25dbc5f000985ee92
😎 Deploy Preview https://deploy-preview-2866--relaxed-lollipop-b6bc17.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@george-gca
Copy link
Collaborator Author

@subhodeeps can you help me here? It's just missing the fix on the layout of the page when on mobile.

@george-gca
Copy link
Collaborator Author

@alshedivat maybe you can help me finish this PR before releasing v1.0? It is only missing the fix on the layout of the page when on mobile. I sometimes struggle with front-end.

@alshedivat
Copy link
Owner

yeah, I can take a look. v1.0 won't be released soon, most likely closer to mid-2025. I'd like to unbundle a lot of functionality into plugins + make a few updates before releasing v1.0.

@george-gca
Copy link
Collaborator Author

I think I will move on with this PR and get it merged, and open an issue related to the front-end part. This code being in the repo is useful to display how someone can create another collection like blog with the template. Also it includes the jekyll-archives-v2.

Signed-off-by: George Araújo <[email protected]>
Signed-off-by: George Araújo <[email protected]>
Signed-off-by: George Araújo <[email protected]>
Signed-off-by: George Araújo <[email protected]>
Signed-off-by: George Araújo <[email protected]>
Signed-off-by: George Araújo <[email protected]>
Signed-off-by: George Araújo <[email protected]>
Signed-off-by: George Araújo <[email protected]>
Signed-off-by: George Araújo <[email protected]>
@george-gca george-gca merged commit 6625f23 into alshedivat:main Feb 28, 2025
10 checks passed
@george-gca george-gca deleted the bookshelf-v2 branch February 28, 2025 16:57
alerezaaa added a commit to alerezaaa/Jekyll_alireza that referenced this pull request Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

digital bookshelf for al-folio
2 participants