Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] "File not found" error is not being logged. #31

Closed
mayurikini opened this issue Nov 6, 2024 · 3 comments
Closed

[Bug] "File not found" error is not being logged. #31

mayurikini opened this issue Nov 6, 2024 · 3 comments

Comments

@mayurikini
Copy link
Contributor

mayurikini commented Nov 6, 2024

The "File not found" error isn't appearing in the log as expected.

I have verified that I can see "Invalid error code" works (https://github.com/altugbakan/rs-tftpd/blob/main/src/packet.rs#L277).
But I am not seeing "File not found" error on the output.

Sample logs:
Here file test exists but abc and pqr doesn't. I expected "FileNotFound" to be logged but it isn't.

Sending test to <>
Invalid code error 
Sending test to <>
Sent test to <>
Sending abc to <>
Sending pqr to <>
@mayurikini mayurikini changed the title [Bug] File not found error is not being logged. [Bug] "File not found" error is not being logged. Nov 6, 2024
@altugbakan
Copy link
Owner

Would you like to work on it?

@stappersg
Copy link
Contributor

stappersg commented Nov 8, 2024 via email

@altugbakan
Copy link
Owner

Fixed with #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants