Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failure logs #32

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Add failure logs #32

merged 3 commits into from
Nov 11, 2024

Conversation

mayurikini
Copy link
Contributor

Issue #31

Add logs for failure cases.

Copy link
Owner

@altugbakan altugbakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good, just a few consistency improvements on sentences.

src/server.rs Outdated Show resolved Hide resolved
src/server.rs Outdated Show resolved Hide resolved
@mayurikini
Copy link
Contributor Author

All tests are passing, this seems like a glitch.

@altugbakan
Copy link
Owner

Can you take a look at it again? If you think there’s a problem I’ll also take a look. Thanks!

@mayurikini
Copy link
Contributor Author

The test that is failing on the build, is passing locally:

image

Is there a command or some way to re-run build/unit test?

@altugbakan altugbakan self-requested a review November 11, 2024 20:02
Copy link
Owner

@altugbakan altugbakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@altugbakan altugbakan merged commit bd92df2 into altugbakan:main Nov 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants