Data Types: Add support for dynamically setting the filter view template #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solflare
changed the title
|
I'm also interested in any ideas for making the labels for the filters dynamic. Not a huge deal but it'd be nice to be able to do |
|
@qschmick Not sure if you've seen this but any thoughts/concerns? ETA: Also, 👋! |
qschmick
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a minor change to allow setting the view for data type's filter when building them.
Any suggestions for other options to allow more control over the displaying of these filters? I had thought about extending the data types themselves but that seemed like overkill for the pure presentation change I need