PHP 8

[therealartz]

As per #480 I'm creating this PR to lock the library to PHP 8.
Updated PHPUnit dependency to ^9.6

Not sure what is situation with CI right now (probably not working).

Min version in composer.json is 8.1, but I tested on 8.3.
Fixed all unit tests to be compatible with PHP 8.1+ and newer version of PHPUnit:

amadeus-ws-client % git branch
  master
* master-php8
amadeus-ws-client % ./vendor/bin/phpunit
PHPUnit 9.6.21 by Sebastian Bergmann and contributors.

...............................................................  63 / 842 (  7%)
............................................................... 126 / 842 ( 14%)
..................................................WW.WW........ 189 / 842 ( 22%)
............................................................... 252 / 842 ( 29%)
............................................................... 315 / 842 ( 37%)
............................................................... 378 / 842 ( 44%)
............................................................... 441 / 842 ( 52%)
............................................................... 504 / 842 ( 59%)
............................................................... 567 / 842 ( 67%)
............................................................... 630 / 842 ( 74%)
............................................................... 693 / 842 ( 82%)
............................................................... 756 / 842 ( 89%)
............................................................... 819 / 842 ( 97%)
.......................                                         842 / 842 (100%)

Time: 00:00.262, Memory: 28.00 MB

There were 4 warnings:

1) Test\Amadeus\Client\Session\Handler\SoapHeader4Test::testCanCreateSoapHeadersForStatelessCall
assertEqualXMLStructure() is deprecated and will be removed in PHPUnit 10.

2) Test\Amadeus\Client\Session\Handler\SoapHeader4Test::testCanCreateSoapHeadersForStatefullCallAuth
assertEqualXMLStructure() is deprecated and will be removed in PHPUnit 10.

3) Test\Amadeus\Client\Session\Handler\SoapHeader4Test::testCanMakeSoapHeadersWithTransactionFlowLink
assertEqualXMLStructure() is deprecated and will be removed in PHPUnit 10.

4) Test\Amadeus\Client\Session\Handler\SoapHeader4Test::testCanMakeSoapHeadersWithTransactionFlowLinkGeneratedGuid
assertEqualXMLStructure() is deprecated and will be removed in PHPUnit 10.

WARNINGS!
Tests: 842, Assertions: 7319, Warnings: 4.

There is no new alternative of assertEqualXMLStructure (seems they decided to just remove this method without replacement, it just stayed a draft), but it should be ok for now.

---

My live application was using this library under PHP 8.3 long enough, didn't know any issues.
Checked under this branch air booking flow and ticketing.

[DerMika]

Can you look at the Scrutinizer build and why that fails? Seems like the right moment to fix that too.

[therealartz]

Can you look at the Scrutinizer build and why that fails? Seems like the right moment to fix that too.

Yeah, I understand.
Could you give add me access to this page? https://scrutinizer-ci.com/g/amabnl/amadeus-ws-client/settings/build-config
I guess something could be in a config at that page, as changing .scrutinizer.yml does not giving any effect

[therealartz]

@DerMika fixed the Scrutinizer

[DerMika]

I guess you can go ahead and release?

I'm not sure if you'll need permissions on packagist.org to publish the new release 🤔
EDIT: made you maintainer there too

[therealartz]

@DerMika thanks. I will do it a bit later (when have free time)