Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flutter-args variable #29

Merged
merged 3 commits into from
Feb 2, 2024
Merged

Conversation

storvik
Copy link
Contributor

@storvik storvik commented Feb 1, 2024

I was going to write an Emacs package for interacting with Flutter. Luckily I googled it and stumbled upon your package. Awesome package, very useful when working with Flutter. I have set after-save-hook to flutter-run-or-hot-reload which makes it hot reload on save, and everything is working smoothly.

The only thing I missed was a way to specify default flags to pass to Flutter. I am working with several projects, some web and some linux. When running flutter I had to C-u M-x flutter-run in order to add -d linux. With this commit it can be specified in .dir-locals.el and therefore set on a per-project basis. I've added a note about this to the readme.

This commit should not break existing functionality as flutter-args is set to nil by default, and then not used in flutter-run.

What do you think? Is this something you could consider adding?

Again, thanks for this package !

This commit makes it possible to run `flutter-run` with `C-u`
to specify args, even if `flutter-args` is set.
Copy link
Owner

@amake amake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I think the idea is a good one. I had some suggestions for improvements.

flutter.el Outdated Show resolved Hide resolved
flutter.el Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@storvik
Copy link
Contributor Author

storvik commented Feb 2, 2024

Thanks for the feedback @amake! Clever to use or instead, didn't think of that.

@storvik storvik requested a review from amake February 2, 2024 12:19
@amake amake merged commit 004c91e into amake:master Feb 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants